Report Generation: Adding basic online evaluation scores#46
Merged
Conversation
amrit110
approved these changes
Feb 17, 2026
Member
amrit110
left a comment
There was a problem hiding this comment.
Just the one comment. Otherwise looks good from my side.
| @@ -37,6 +38,7 @@ def get_report_generation_agent( | |||
| instructions: str, | |||
| reports_output_path: Path, | |||
| langfuse_project_name: str | None, | |||
Member
There was a problem hiding this comment.
I think this new parameter is missing a docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding basic online evaluations for the report generation agent. Those evaluations are meant to be run by the "production" environment and will produce and upload scores to langfuse on the following:
langfuse.pyso they can be easily reused by other agentsThis is how it those scores are displayed in the Langfuse UI:

Trace detail page:
Dashboard page:

Clickup Ticket(s): NA
Type of Change
Changes Made
langfuse.pyto upload scores on latency, token count and cost for a traceTesting
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
Tested the UI and checked the resulting scores in langfuse.
Checklist